-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final_gas_pipelines #251
Merged
Merged
Final_gas_pipelines #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
…h-sec into Gas_pipelines
for more information, see https://pre-commit.ci
…h-sec into Gas_pipelines
for more information, see https://pre-commit.ci
…h-sec into Gas_pipelines
for more information, see https://pre-commit.ci
energyLS
reviewed
Jan 11, 2024
test/config.test1.yaml
Outdated
@@ -13,7 +13,7 @@ scenario: | |||
simpl: # only relevant for PyPSA-Eur | |||
- "" | |||
clusters: # number of nodes in Europe, any integer between 37 (1 node per country-zone) and several hundred | |||
- 4 | |||
- 74 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert back to 4
energyLS
reviewed
Jan 11, 2024
hazemakhalek
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert back the countries to ["MA"] as discussed in a following PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18 #220 #236 (if applicable).
Changes proposed in this Pull Request
This PR adds a new rule to the workflow to prepare an existing gas network representation between the nodes:
The user is able to choose in the .config file to either:
The rule was tested for Voronoi and GADM clustering.
You can see some examples of existing gas network and result below:
Checklist
envs/environment.yaml
andenvs/environment.docs.yaml
.config.default.yaml
,config.tutorial.yaml
, andtest/config.test1.yaml
.doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.