Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final_gas_pipelines #251

Merged
merged 20 commits into from
Jan 31, 2024
Merged

Conversation

Eddy-JV
Copy link
Collaborator

@Eddy-JV Eddy-JV commented Dec 6, 2023

Closes #18 #220 #236 (if applicable).

Changes proposed in this Pull Request

This PR adds a new rule to the workflow to prepare an existing gas network representation between the nodes:

  1. The user is able to choose in the .config file to either:

    • Add a custom gas network .csv file.
    • Choose between two built-in datasets:
      • Global: Global Energy Monitor (GGIT)
      • European: SciGrid (IGGIELGN)
    • Or just use a uniform fictive network between all nodes.
  2. The rule was tested for Voronoi and GADM clustering.

  3. You can see some examples of existing gas network and result below:
    existing_gas_pipelines_TR_Clustered
    existing_gas_pipelines_TR_IGGIELGN

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@energyLS energyLS mentioned this pull request Dec 11, 2023
@@ -13,7 +13,7 @@ scenario:
simpl: # only relevant for PyPSA-Eur
- ""
clusters: # number of nodes in Europe, any integer between 37 (1 node per country-zone) and several hundred
- 4
- 74
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert back to 4

test/config.test1.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@hazemakhalek hazemakhalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert back the countries to ["MA"] as discussed in a following PR.

@hazemakhalek hazemakhalek merged commit 1bfaca0 into pypsa-meets-earth:main Jan 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

osm gas_network
3 participants