fix HTTP error 403: forbidden #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
energyLS
reviewed
Jan 30, 2024
| @@ -20,8 +20,7 @@ def download_ports(): | |||
| The following csv file was downloaded from the webpage https://msi.nga.mil/Publications/WPI as a csv file that is updated monthly as mentioned on the webpage. The dataset contains 3711 ports. | |||
| """ | |||
| fn = "https://msi.nga.mil/api/publications/download?type=view&key=16920959/SFH00000/UpdatedPub150.csv" | |||
| storage_options = {"User-Agent": "Mozilla/5.0"} | |||
| wpi_csv = pd.read_csv(fn, index_col=0, storage_options=storage_options) | |||
| wpi_csv = pd.read_csv(fn, index_col=0) | |||
There was a problem hiding this comment.
can you explain why storage_options is deleted and what the purpose was?
There was a problem hiding this comment.
@energyLS When downloading csv files with pd.read_csv, the storage_options are transferred as header in the request. They are there to make the request look more "credible", in this case to indicate that the request is being sent from a Mozilla Firefox browser. For some reason, however, this is exactly what triggers this HTTP error 403. As soon as we do not send this header, we get the data packet returned. :)
There was a problem hiding this comment.
Thanks, great catch. Merging!
energyLS
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes # (if applicable).
Changes proposed in this Pull Request
deleted storage options to fix HTTP 403 forbidden error
Checklist
envs/environment.yamlandenvs/environment.docs.yaml.config.default.yaml,config.tutorial.yaml, andtest/config.test1.yaml.doc/configtables/*.csvand line references are adjusted indoc/configuration.rstanddoc/tutorial.rst.doc/release_notes.rstis amended in the format of previous release notes, including reference to the requested PR.