Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve pandas deprecations #319

Closed
wants to merge 10 commits into from
Closed

Resolve pandas deprecations #319

wants to merge 10 commits into from

Conversation

finozzifa
Copy link
Contributor

@finozzifa finozzifa commented May 30, 2024

Closes # (if applicable).

Closes issue #314

Changes proposed in this Pull Request

Resolve the pandas deprecations listed in issue #314.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@davide-f davide-f mentioned this pull request Jun 5, 2024
18 tasks
Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @finozzifa :D
To me the code seems smooth, really great job and pace!
I see the use of .T that sometimes can be a bit tricky; have you tested and verified that outputs numerically match?
By reviewing the code, it seems fine, but I'd personally perform two checks:

  1. that in debug the output of that code works fine
  2. the output of the solve_network is the same as before
    I'm sure you have done that, this is maybe being extra cautious, apologies

@finozzifa finozzifa closed this by deleting the head repository Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants