Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snakemake module #367

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Snakemake module #367

wants to merge 18 commits into from

Conversation

FabianHofmann
Copy link
Collaborator

This change proposes to replace snakemake the subworkflow approach with a submodule approach. As discussed this is sill in the testing phase (CI will likely fail in the first iterations).

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@energyLS
Copy link
Collaborator

@FabianHofmann thanks for setting up the PR! Do you need any support, or is any review required yet? If so, just let me know.

@FabianHofmann
Copy link
Collaborator Author

Thank you @energyLS, I am still playing a little bit, but I am making good progress.

A short question regarding the log. Is there any way to suppress the quite verbose two outputs:

  1. the progress bar like in https://github.com/pypsa-meets-earth/pypsa-earth-sec/actions/runs/10320381005/job/28570828550#step:8:199
  2. the regular expression matches https://github.com/pypsa-meets-earth/pypsa-earth-sec/actions/runs/10320381005/job/28570828550#step:8:487

Looked a little but so far I could not find which rule triggers these logs.

@FabianHofmann
Copy link
Collaborator Author

FabianHofmann commented Aug 13, 2024

@ekatef as you were having issues with the environment. In this PR, the CI for both Mac and Ubuntu is working. I think it is mainly because the CI uses micromamba which is faster and more stable as far as I experienced.

@ekatef
Copy link
Member

ekatef commented Aug 13, 2024

@ekatef as you were having issues with the environment. In this PR, the CI for both Mac and Ubuntu is working. I think it is mainly because the CI uses micromamba which is faster and more stable as far as I experienced.

Hey @FabianHofmann, thanks for notifying! I'm still puzzled about the environment troubles for mac... We had an impression that the troubles are caused by a transition from conda 24.4 to conda 24.7 also in CI, but didn't find a way to fix it as far as having a restriction on conda version doesn't have much effect.

So, great news that the CI is working now which seems to be the case also with conda 24.7.1! Let's hope that this issue will just disappear also in other places [personally, I'd very much appreciate that! 🙃]

@FabianHofmann
Copy link
Collaborator Author

Yes, it can be a real pain sometimes... fingers crossed that this will resolve also in the long term :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants