-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert conventional ppls from generators to link with existing capacity #1165
Convert conventional ppls from generators to link with existing capacity #1165
Conversation
Similar to |
Another thing that I want to discuss is the possibility to rename spatial bus names from |
Hi, @davide-f. It would be great to hear your opinion on this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @yerbol-akhmetov :D
The PR looks quite nice to me.
Beyond the comments here; I'd recommend to check at least a test config file, to ensure the new code is well tested and included in the CI. For example the spatial_lignite: false.
Great contribution!!!
Update: In agreement to the -sec meeting, we may have also a view of this PR by hazem
Thanks, @davide-f, for suggestion. I have renamed all Africa instances to Earth. |
Merging :D Congratulations! |
Changes proposed in this Pull Request
Good day. I am proposing to convert conventional generators (e.g. coal, lignite, biomass, oil and etc) from generators to link with stores and generators. Currently it is implemented for OCGT in
add_generation
function ofprepare_sector_networks
and oil inadd_oil
functions. However, the current implementation is not fully correct as existing OCGT generators from elec network is not removed when added as a link.This PR aims to convert technologies listed in
conventional_generation
section ofsector
section of config to links, and remove from generators. Having stores and links for conventional carriers is practical when defining new technologies that uses those carriers (eg. carbon capture). In addition, it will be possible to keep existing capacities and transfer them to links based on the option in config.Checklist
config.default.yaml
andconfig.tutorial.yaml
.doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.