Drop non string entries in country column of CO2_emissions data in prepare_transport_data_input

[yerbol-akhmetov]

Changes proposed in this Pull Request

Good day. Here I propose to update download_co2_emissions function in prepare_transport_data_input.py script to drop entries where country column contains not string. This issue appeared very recently, as I have noticed it in the CI check. Great thanks for @finozzifa, who pointed out the error location and proposed the solution.

Checklist

• I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
• I tested my contribution locally and it seems to work fine.
• A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

[yerbol-akhmetov]

Hi, @hazemakhalek. Can you please review the bug fix provided in this PR? Currently CI fails due to that too.

[hazemakhalek]

Hi Yerbol, this part I believe is legacy code that is not used anymore. Can you please confirm that in prepare_sector_network.py (this should be the only script we use this output file) and then we can omit the part of the emissions here altogether?

[yerbol-akhmetov]

Hi Yerbol, this part I believe is legacy code that is not used anymore. Can you please confirm that in prepare_sector_network.py (this should be the only script we use this output file) and then we can omit the part of the emissions here altogether?

Hi, @hazemakhalek. I have checked the prepare_transport_data_input rule. Its output is used in prepare_transport_data. This rule has an output of transport data (resources/demand/transport_...), which is used in prepare_sector_network rule to define the demand for land transport (using add_land_transport). I think it is not redundant, no?

[hazemakhalek]

Hi Yerbol, thanks for taking the time to check it. I meant only the CO2 emission part, not the whole file. Is it still being used in prepare_sector_network?

[yerbol-akhmetov]

Hi Yerbol, thanks for taking the time to check it. I meant only the CO2 emission part, not the whole file. Is it still being used in prepare_sector_network?

Sorry @hazemakhalek for not mentioning, CO2_emissions_csv data have average_fuel_efficiency column, which is used in further rule prepare_transport_data:

pypsa-earth/scripts/prepare_transport_data.py

Lines 99 to 112 in 1075456

	transport_data = pd.read_csv(
	snakemake.input.transport_name, index_col=0, keep_default_na=False
	)
	nodal_transport_data = transport_data.reindex(pop_layout.ct, fill_value=0.0)
	nodal_transport_data.index = pop_layout.index
	nodal_transport_data["number cars"] = (
	pop_layout["fraction"] * nodal_transport_data["number cars"]
	)
	nodal_transport_data.loc[
	nodal_transport_data["average fuel efficiency"] == 0.0,
	"average fuel efficiency",
	] = transport_data["average fuel efficiency"].mean()

[davide-f]

Added a comment; what do you think?

[davide-f]

Great @yerbol-akhmetov and thanks for the clarification.
A minor stylistic comment, ready to merge right after

[davide-f]

Many thanks :D merged :)