-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coal and gas CC technologies #1200
Draft
yerbol-akhmetov
wants to merge
10
commits into
pypsa-meets-earth:main
Choose a base branch
from
yerbol-akhmetov:add_coal_cc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9bbda88
add coal CC technologies
yerbol-akhmetov ea689a8
read fixed cost and VOM of CC technology directly
yerbol-akhmetov 8521eb7
add gas CC technologies
yerbol-akhmetov 087624d
add coal IGCC technology
yerbol-akhmetov f13e036
add gas NGCC technology
yerbol-akhmetov debd0c5
Merge branch 'main_origin' into add_coal_cc
yerbol-akhmetov d5e84fb
Merge branch 'main_origin' into add_coal_cc
yerbol-akhmetov 08bf56f
use full names to define CC technologies
yerbol-akhmetov 9d82bc3
Merge branch 'main_origin' into add_coal_cc
yerbol-akhmetov b096a09
remove scenario from costs
yerbol-akhmetov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My feeling is that it would be great to keep harmonise using upper and lowercase across the code: we have lower-cased
cc
for industry and co-generation here, while upper-case is used for steam methane reforming and thermal power plants in this PR. Can we align that somehow?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, my thought was to change everywhere to uppercase
CC
. As it is strange that inSMR CC
it is uppercase, while justcc
is lowercase. I can make those changes within this PR if you agree.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally agree 🙂