Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Length based pipeline efficiency #1215

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Eric-Nitschke
Copy link

@Eric-Nitschke Eric-Nitschke commented Nov 29, 2024

!!!Not tested yet, don't review!!!

Closes #1213.

Changes proposed in this Pull Request

Major changes:

  • change the efficiency of H2 pipelines from a static value (that is somewhat faulty see BR Hydrogen pipeline efficiency #1213) to a length based calculation similar to PyPSA-Eur in scripts/add_extra_components.py.

Minor changes:

  • override the networks component attributes in scripts/add_extra_components.py and scripts/solve_network.py to accomodate the length based efficiencies.
  • add the transmission efficiencies of H2 pipelines to the config.

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

Eric-Nitschke and others added 2 commits November 29, 2024 16:54
Major changes:
- change the efficiency of H2 pipelines from a static value (that is somewhat faulty see BR pypsa-meets-earth#1213) to a length based calculation similar to PyPSA-Eur in scripts/add_extra_components.py.

Minor changes:
- override the networks component attributes in scripts/add_extra_components.py and scripts/solve_network.py to accomodate the length based efficiencies.
- add the transmission efficiencies of H2 pipelines to the config.
@Eric-Nitschke Eric-Nitschke mentioned this pull request Dec 3, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydrogen pipeline efficiency
1 participant