Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update FT to account for Hydrogen and Electricity input #1226

Merged
merged 10 commits into from
Dec 23, 2024
+4 −0
Merged

update FT to account for Hydrogen and Electricity input #1226

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
dd20980
update FT to account for Hydrogen and electricity input
GbotemiB Dec 5, 2024
b94cb9b
revert implementation
GbotemiB Dec 12, 2024
f8d9c3a
include electricity bus
GbotemiB Dec 12, 2024
5cff276
Merge branch 'pypsa-meets-earth:main' into update-FT
GbotemiB Dec 12, 2024
78edb91
added electricity bus
GbotemiB Dec 13, 2024
ce16c42
revert snakemock
GbotemiB Dec 13, 2024
29b1be2
Merge branch 'pypsa-meets-earth:main' into update-FT
GbotemiB Dec 20, 2024
c37002c
Update release_notes.rst
GbotemiB Dec 20, 2024
ff83efd
revert efficiency for FT
GbotemiB Dec 21, 2024
f4cc2de
Merge branch 'main' into update-FT
GbotemiB Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions scripts/prepare_sector_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,13 +171,13 @@ def H2_liquid_fossil_conversions(n, costs):
bus1=spatial.oil.nodes,
bus2=spatial.co2.nodes,
carrier="Fischer-Tropsch",
efficiency=costs.at["Fischer-Tropsch", "efficiency"],
efficiency=1 / costs.at["Fischer-Tropsch", "electricity-input"],
efficiency2=costs.at["Fischer-Tropsch", "hydrogen-input"]
/ costs.at["Fischer-Tropsch", "electricity-input"],
capital_cost=costs.at["Fischer-Tropsch", "fixed"]
* costs.at[
"Fischer-Tropsch", "efficiency"
], # Use efficiency to convert from EUR/MW_FT/a to EUR/MW_H2/a
efficiency2=-costs.at["oil", "CO2 intensity"]
* costs.at["Fischer-Tropsch", "efficiency"],
/ costs.at["Fischer-Tropsch", "electricity-input"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think capital_cost should be multiplication of fixed with efficiency as previously defined.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, see comment below

marginal_cost=costs.at["Fischer-Tropsch", "VOM"]
/ costs.at["Fischer-Tropsch", "electricity-input"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same is true for marginal_cost. Efficiency should be multiplied. @davide-f, can you please comment? Also generally efficiency is used rather than electricity-input.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed the multiplication with efficiency is appropriate because of the unit of measurement used for the calculation.
Regarding this PR, I'm adding a comment below also

p_nom_extendable=True,
p_min_pu=options.get("min_part_load_fischer_tropsch", 0),
lifetime=costs.at["Fischer-Tropsch", "lifetime"],
Expand Down
Loading