Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Fix admin needs for Windows #1295

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

Eric-Nitschke
Copy link
Contributor

I assume, that PR #790 should be applied to each rule using a shadow directory, rather than just one specific instance. This PR changes this.

Changes proposed in this Pull Request

Minor changes:

  • fix the admin needs for Windows by setting every shadow directory settings in the Snakefile to "copy-minimal" for Windows

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

Minor changes:
- fix the admin needs for Windows by setting the shadow directory settings in the Snakefile to "copy-minimal" for Windows
@Eric-Nitschke Eric-Nitschke mentioned this pull request Jan 14, 2025
8 tasks
Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @Eric-Nitschke :D
Thanks for testing windows support!
Could be interesting to see if once after #1276 is merged this requirement will be needed.
Merging as CI passes :)

Eddy-JV added a commit to Eric-Nitschke/pypsa-earth-bidirectional_lossy_links that referenced this pull request Jan 15, 2025
@davide-f davide-f merged commit e393855 into pypsa-meets-earth:main Jan 15, 2025
6 checks passed
@davide-f
Copy link
Member

Merged :D many thanks for the contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants