Geoboundaries as an alternative to GADM #1370
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1258
Changes proposed in this Pull Request
Add the option to use a more permissive geographic administration data source. Doing this requires a few steps:
gadm()
to only be frombuild_shapes.py
. This is done by cleaning upprepare_gas_network.py
. Additionally I've created the rule to make the plot for the gas networkgeoboundaries()
inbuild_shapes.py
that is activated if the configadmin_shape: "geoboundaries"
TODO:
@ekatef @davide-f looking forward for the technical review when you have the spare time.
Checklist
envs/environment.yaml
anddoc/requirements.txt
.config.default.yaml
andconfig.tutorial.yaml
.test/
(note tests are changing the config.tutorial.yaml)doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.