Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nondeterminism in test_distribution_generic #454

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Remove nondeterminism in test_distribution_generic #454

merged 1 commit into from
Feb 3, 2021

Conversation

eb8680
Copy link
Member

@eb8680 eb8680 commented Feb 3, 2021

Resolves #441

@eb8680 eb8680 added awaiting review bug Something isn't working easy testing labels Feb 3, 2021
@eb8680 eb8680 requested a review from fritzo February 3, 2021 04:34
@eb8680 eb8680 mentioned this pull request Feb 3, 2021
Merged
4 tasks
fritzo
fritzo approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean!

@fritzo fritzo merged commit 7a56805 into master Feb 3, 2021
@fritzo fritzo deleted the make-dist-test-deterministic branch February 3, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzo fritzo fritzo approved these changes

Assignees
No one assigned
Labels
awaiting review bug Something isn't working easy testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nondeterministic failure in test_distribution_generic.py
2 participants
@eb8680 @fritzo