Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dim,keepdims to Funsor.sum() method #503

Closed
wants to merge 1 commit into from
Closed

Add dim,keepdims to Funsor.sum() method #503

wants to merge 1 commit into from

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Mar 19, 2021

Addresses #489
Follows #490

This adds dim=None, keepdims=False parameters to the Funsor.sum() method. I'm hoping @ordabayevy will be able to add similar methods in #482 .

Tested

  • added more checks to test/test_tensor.py::test_sum

@fritzo fritzo added enhancement New feature or request awaiting review easy labels Mar 19, 2021
@fritzo fritzo mentioned this pull request Mar 19, 2021
Closed
4 tasks
@ordabayevy
Copy link
Member

I made similar changes for all of the reduction ops in #482 .

@fritzo fritzo mentioned this pull request Mar 19, 2021
Merged
@fritzo
Copy link
Member Author

fritzo commented Mar 19, 2021

Closing in favor of #482

@fritzo fritzo closed this Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eb8680 eb8680 Awaiting requested review from eb8680

@ordabayevy ordabayevy Awaiting requested review from ordabayevy

Assignees
No one assigned
Labels
awaiting review easy enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fritzo @ordabayevy