Memoize Transform.inv #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
fritzo
force-pushed
the
transform-inv-weakref
branch
from
08c98b7
to
bdf6d77
Compare
fehiepsi
reviewed
Jan 21, 2021
| @@ -1038,6 +1038,7 @@ def test_bijective_transforms(transform, event_shape, batch_shape): | |||
| z = transform.inv(y) | |||
| assert_allclose(x, z, atol=1e-6, rtol=1e-6) | |||
| assert transform.inv.inv is transform | |||
| assert transform.inv is transform.inv | |||
fehiepsi
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes behavior mismatch blocking pyro-ppl/funsor#427 identified by @eb8680
This makes NumPyro's
Transform.invproperty act more like PyTorch's.Tested