-
-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support inference with RenyiELBO for local latent variable models #3123
base: dev
Are you sure you want to change the base?
Conversation
Should I ignore notebooks when using black? When running |
Yes could you please ignore notebooks? The easiest way to do so is to run black through |
Sure, no problem.
Looking at the format target in the Makefile, it seems it's only black that needs a section in the TOML file. I'll configure a pyproject.toml and update the Makefile. |
|
||
|
||
@pytest.mark.stage("integration", "integration_batch_2") | ||
class OneWayNormalRandomEffects(TestCase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how much time do these tests take?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how much time do these tests take?
In CI :
Time [sec] | |
---|---|
test_renyi_nonreparameterized |
50.67 |
test_renyi_reparameterized |
36.59 |
test_renyi_vectorized |
36.32 |
So all are in the top ten slowest for batch 2.
@martinjankowiak, can you suggest a plating structure where we need to compute the dependence (i.e., |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OlaRonning will this still give results for a local latent variable model like a VAE with a data plate
? why doesn't this logic sum out the data plate dimension?
@martinjankowiak, sorry for the late reply.
From my understanding, this corresponds to including the data plate dimension in |
Addresses #3104
TODO
logsumexp
reduction dim for LLV model