-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exposing mapping_distance in travel builder #756
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Martin Fleischmann <[email protected]>
Co-authored-by: Martin Fleischmann <[email protected]>
Co-authored-by: Martin Fleischmann <[email protected]>
Co-authored-by: Martin Fleischmann <[email protected]>
Co-authored-by: James Gaboardi <[email protected]>
Co-authored-by: James Gaboardi <[email protected]>
Co-authored-by: James Gaboardi <[email protected]>
Co-authored-by: James Gaboardi <[email protected]>
Co-authored-by: James Gaboardi <[email protected]>
Co-authored-by: James Gaboardi <[email protected]>
… your fault james!!! :P
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
=======================================
+ Coverage 85.3% 85.4% +0.1%
=======================================
Files 149 150 +1
Lines 15914 15975 +61
=======================================
+ Hits 13580 13641 +61
Misses 2334 2334
|
Did I jump the gun on merging #755 ? |
not really i pushed this the instant you hit merge. I think this can just go in |
and it switches the docstrings, which i think is more useful. The private funcs had the more descriptive docs last time |
network : pandana.Network | ||
pandana Network object describing travel costs between nodes in the study | ||
area | ||
area. See <https://udst.github.io/pandana/> for more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably use intersphinx here to link to the class but that is a just a minor detail.
expose mapping_distance
this just allows you to pass a mapping_distance through to pandana's snapping mechanism but it induced some formatting changes