Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exposing mapping_distance in travel builder #756

Merged
merged 32 commits into from
Jul 18, 2024
Merged

Conversation

knaaptime
Copy link
Member

@knaaptime knaaptime commented Jul 18, 2024

expose mapping_distance

this just allows you to pass a mapping_distance through to pandana's snapping mechanism but it induced some formatting changes

knaaptime and others added 30 commits July 17, 2024 16:16
Co-authored-by: Martin Fleischmann <[email protected]>
Co-authored-by: Martin Fleischmann <[email protected]>
Co-authored-by: Martin Fleischmann <[email protected]>
Co-authored-by: Martin Fleischmann <[email protected]>
@knaaptime knaaptime changed the title pdnagraph exposing mapping_distance in travel builder Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.4%. Comparing base (8c0bc1f) to head (099bcfc).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #756     +/-   ##
=======================================
+ Coverage   85.3%   85.4%   +0.1%     
=======================================
  Files        149     150      +1     
  Lines      15914   15975     +61     
=======================================
+ Hits       13580   13641     +61     
  Misses      2334    2334             
Files Coverage Δ
libpysal/graph/_network.py 100.0% <100.0%> (ø)
libpysal/graph/base.py 96.5% <100.0%> (+0.1%) ⬆️

... and 1 file with indirect coverage changes

@jGaboardi
Copy link
Member

Did I jump the gun on merging #755 ?

@knaaptime
Copy link
Member Author

not really i pushed this the instant you hit merge. I think this can just go in

@knaaptime
Copy link
Member Author

and it switches the docstrings, which i think is more useful. The private funcs had the more descriptive docs last time

@knaaptime knaaptime merged commit 0fb5c25 into pysal:main Jul 18, 2024
12 checks passed
network : pandana.Network
pandana Network object describing travel costs between nodes in the study
area
area. See <https://udst.github.io/pandana/> for more
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably use intersphinx here to link to the class but that is a just a minor detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants