-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exponential kernel to Graph #761
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #761 +/- ##
=====================================
Coverage 85.4% 85.4%
=====================================
Files 150 150
Lines 15975 15989 +14
=====================================
+ Hits 13641 13655 +14
Misses 2334 2334
|
@@ -106,6 +112,7 @@ def _kernel( | |||
- gaussian: | |||
- bisquare: | |||
- cosine: | |||
- exponential: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these all probably have formulas here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
no way to bound it at the bandwidth if you want though 🤷♂️. would require another argument |
Thinking about this more, I am actually not sure if I like passing alpha as |
No description provided.