add no-cache headers #133
Merged
add no-cache headers #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the MR looks good but is there any reason no description is presented? I've no idea what I am approving otherwise, thanks for any sort of clarification, this header is hostile for mobile data too so I'd love to have at least a hint around why this is needed. |
FabioRosado
reviewed
Feb 14, 2024
There was a problem hiding this comment.
@madhur-tandon Do you remember why we need this? We can now merge stuff
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
=======================================
Coverage 96.23% 96.23%
=======================================
Files 5 5
Lines 292 292
=======================================
Hits 281 281
Misses 11 11 ☔ View full report in Codecov by Sentry. |
FabioRosado
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.