-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add atomlist to store and read complexes #275
Conversation
95932ef
to
ea89cb0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
==========================================
- Coverage 96.87% 96.81% -0.06%
==========================================
Files 32 35 +3
Lines 3518 3610 +92
==========================================
+ Hits 3408 3495 +87
- Misses 110 115 +5 ☔ View full report in Codecov by Sentry. |
efb334f
to
84fdb9d
Compare
This is ready for review now. In a following step, we should migrate datasets relying on pickle to other formats. |
84fdb9d
to
4e85c58
Compare
4e85c58
to
d009ab8
Compare
I am not exactly sure how to deal with the documentation issues raised my numpydoc. It complains about a lack of documentation for Thus I would think that they should not have a docstring, the function is documented in the "actual" implementation (the last without |
HI @ffl096 Yes we can do that, see karate_club at: https://github.com/pyt-team/TopoNetX/blob/main/toponetx/datasets/graph.py Essentially just leave an inline comment I also raised an issue #326 where majority of the docstrings issues are due to overloaded methods, maybe we can tick them off as well if we are planning to skip them. |
Yes we should ignore them. I was just wondering if we can automatically do that for all overloaded functions (as done for code coverage), but didn't found a way to do that. Adding the ignore every time is also fine though. |
3268a2a
to
e06b6e6
Compare
e06b6e6
to
7e5363f
Compare
Introduce functions for "atom lists", which work similar to edge lists and allow to store and load complexes.
Background: Right now, we ship some datasets in form of pickled data structures. While this was a fast way to implement this problem, it is a really bad idea for various reasons. It is highly unstable as it relies on internal state of data structures and any change to them breaks the datasets. In fact, this is what blocks #220, which completely overhauls the internals of
SimplicialComplex
.