Fix bug in invalid_range_checker #968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChristopherLi05 thank you for making this, but I merged in #969 instead (to spread the opportunities for contribution around). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Addresses #967
Your Changes
Description:
invalid_range_checker.py, I reversed the signs on lines 52 and 53 to fix the buginvalid_range_checker.py, I addedand not isinstance(item, nodes.UnaryOp)because negative numbers wouldn't be caughttest_invalid_range_checker.pysince there was no test written for itType of change (select all that apply):
Testing
Created
test_invalid_range_checker.pyand made sure all the checks would passChecklist