Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accumulation table bug fix #982

Merged
merged 16 commits into from
Dec 2, 2023

Conversation

AinaMerch
Copy link
Contributor

Motivation and Context

Loop variable state is stored by creating shallow copies of the objects. Loops that mutate a nested part of an object will not have their state displayed properly. We need to fix this by creating deep copies.

https://www.cs.toronto.edu/~david/pyta/debug/
Limitation 3

Your Changes

Changed _record_iteration() to make deep copies.

Description:

Type of change (select all that apply):

  • Bug fix (non-breaking change which fixes an issue)

Testing

Ran it on demo code and ensured it gave the correct values.

Questions and Comments (if applicable)

Checklist

  • I have performed a self-review of my own code.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported on Coveralls.

@coveralls
Copy link
Collaborator

coveralls commented Nov 14, 2023

Pull Request Test Coverage Report for Build 7062851422

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.638%

Totals Coverage Status
Change from base Build 6938205699: 0.0%
Covered Lines: 3442
Relevant Lines: 3637

💛 - Coveralls

Copy link
Contributor

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AinaMerch good work. So in addition to updating the changelog, you should add test cases to illustrate this new behaviour.

Oh yes, and make sure to also update the documentation website to remove this limitation!

Copy link
Contributor

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AinaMerch good job adding test cases. You should update the documentation webpage to remove the mention of the limitation you fixed.

@david-yz-liu david-yz-liu merged commit 12deaad into pyta-uoft:master Dec 2, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants