-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accumulation table bug fix #982
Accumulation table bug fix #982
Conversation
…ulation-table-bug-fix
Pull Request Test Coverage Report for Build 7062851422
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AinaMerch good work. So in addition to updating the changelog, you should add test cases to illustrate this new behaviour.
Oh yes, and make sure to also update the documentation website to remove this limitation!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AinaMerch good job adding test cases. You should update the documentation webpage to remove the mention of the limitation you fixed.
Motivation and Context
Loop variable state is stored by creating shallow copies of the objects. Loops that mutate a nested part of an object will not have their state displayed properly. We need to fix this by creating deep copies.
https://www.cs.toronto.edu/~david/pyta/debug/
Limitation 3
Your Changes
Changed _record_iteration() to make deep copies.Description:
Type of change (select all that apply):
Testing
Ran it on demo code and ensured it gave the correct values.
Questions and Comments (if applicable)
Checklist