Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message for not collected tasks with @task decorator. #521

Merged
merged 8 commits into from
Dec 12, 2023

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Dec 8, 2023

Closes #513.

@tobiasraabe tobiasraabe added this to the v0.4.5 milestone Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (88a5fb1) 96.96% compared to head (96a337b) 96.96%.

Files Patch % Lines
src/_pytask/collect.py 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
- Coverage   96.96%   96.96%   -0.01%     
==========================================
  Files         104      104              
  Lines        8974     8997      +23     
==========================================
+ Hits         8702     8724      +22     
- Misses        272      273       +1     
Flag Coverage Δ
end_to_end 82.13% <40.00%> (-0.12%) ⬇️
integration 40.06% <16.00%> (-0.10%) ⬇️
unit 68.84% <88.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobiasraabe tobiasraabe enabled auto-merge (squash) December 12, 2023 23:00
@tobiasraabe tobiasraabe merged commit f0d5994 into main Dec 12, 2023
24 of 25 checks passed
@tobiasraabe tobiasraabe deleted the fix-513 branch December 12, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: using pytask.task()(func_defined_in_other_file) doesn't work
1 participant