-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rule feature #728
Add rule feature #728
Conversation
Add changelog entry Add README entry Add tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #728 +/- ##
==========================================
- Coverage 95.74% 95.70% -0.05%
==========================================
Files 54 55 +1
Lines 2114 2187 +73
Branches 228 192 -36
==========================================
+ Hits 2024 2093 +69
- Misses 55 58 +3
- Partials 35 36 +1 ☔ View full report in Codecov by Sentry. |
@youtux Created a new PR with the rule feature in as I messed up the rebasing! |
Co-authored-by: Alessio Bogon <[email protected]>
Co-authored-by: Alessio Bogon <[email protected]>
Co-authored-by: Alessio Bogon <[email protected]>
Co-authored-by: Alessio Bogon <[email protected]>
Co-authored-by: Alessio Bogon <[email protected]>
Co-authored-by: Alessio Bogon <[email protected]>
# Conflicts: # CHANGES.rst
Implemented all feedback. Just this: #728 (comment) I think needs to be as it is, so we know what type of background it is (under a feature or under rule), but may have misunderstood the suggestion! |
Hero thanks for implementing this and the data tables work. <3 |
Pleasure! Glad it is hopefully helpful! |
@youtux is there anything else after this that would be necessary for a V8 release? (I'm assuming https://github.com/pytest-dev/pytest-bdd/milestone/1 is our definition of what we want to achieve for v8? If so, I can pick up the multiple examples table one and then i think that's it in terms of features) |
Not necessarily. If #489 is not a backwards incompatible change, it can go in a minor release. I think if we merge this we can release v8.0.0. |
Unless there are outstanding issues I forgot about |
I'll try reviewing this in the weekend if I manage |
No rush at all - Appreciated as always! |
Committed responses to latest feedback :) |
Removed feature field from Rule |
Feedback resolved :) |
Addressed feedback :) |
# Conflicts: # CHANGES.rst # src/pytest_bdd/parser.py # src/pytest_bdd/scenario.py
@youtux tried rerunning the checks, but codecov consistently seems unhappy. Not sure what's happening... |
Yeah there's something going on with codecov. I'll merge this manually |
Resolves Rule keyword #511