Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule feature #728

Merged
merged 21 commits into from
Nov 13, 2024
Merged

Add rule feature #728

merged 21 commits into from
Nov 13, 2024

Conversation

jsa34
Copy link
Collaborator

@jsa34 jsa34 commented Oct 20, 2024

Add changelog entry
Add README entry
Add tests
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 5 lines in your changes missing coverage. Please review.

Project coverage is 95.70%. Comparing base (f47c6d2) to head (d67a7b8).

Files with missing lines Patch % Lines
src/pytest_bdd/gherkin_terminal_reporter.py 72.22% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #728      +/-   ##
==========================================
- Coverage   95.74%   95.70%   -0.05%     
==========================================
  Files          54       55       +1     
  Lines        2114     2187      +73     
  Branches      228      192      -36     
==========================================
+ Hits         2024     2093      +69     
- Misses         55       58       +3     
- Partials       35       36       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsa34
Copy link
Collaborator Author

jsa34 commented Oct 20, 2024

@youtux Created a new PR with the rule feature in as I messed up the rebasing!

@jsa34 jsa34 requested a review from youtux October 20, 2024 18:01
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
src/pytest_bdd/generation.py Outdated Show resolved Hide resolved
src/pytest_bdd/generation.py Outdated Show resolved Hide resolved
src/pytest_bdd/gherkin_terminal_reporter.py Show resolved Hide resolved
tests/feature/test_gherkin_terminal_reporter.py Outdated Show resolved Hide resolved
tests/feature/test_rule_example_format.py Outdated Show resolved Hide resolved
tests/feature/test_rule_example_format.py Outdated Show resolved Hide resolved
tests/feature/test_rule_example_format.py Outdated Show resolved Hide resolved
tests/feature/test_rule_example_format.py Outdated Show resolved Hide resolved
@jsa34
Copy link
Collaborator Author

jsa34 commented Nov 5, 2024

Implemented all feedback.

Just this: #728 (comment) I think needs to be as it is, so we know what type of background it is (under a feature or under rule), but may have misunderstood the suggestion!

@Poogles
Copy link

Poogles commented Nov 7, 2024

Hero thanks for implementing this and the data tables work. <3

@jsa34
Copy link
Collaborator Author

jsa34 commented Nov 7, 2024

Pleasure!

Glad it is hopefully helpful!

@jsa34
Copy link
Collaborator Author

jsa34 commented Nov 8, 2024

@youtux is there anything else after this that would be necessary for a V8 release? (I'm assuming https://github.com/pytest-dev/pytest-bdd/milestone/1 is our definition of what we want to achieve for v8? If so, I can pick up the multiple examples table one and then i think that's it in terms of features)

@youtux
Copy link
Contributor

youtux commented Nov 8, 2024

Not necessarily. If #489 is not a backwards incompatible change, it can go in a minor release.

I think if we merge this we can release v8.0.0.

@youtux
Copy link
Contributor

youtux commented Nov 8, 2024

Unless there are outstanding issues I forgot about

@youtux
Copy link
Contributor

youtux commented Nov 8, 2024

I'll try reviewing this in the weekend if I manage

@jsa34
Copy link
Collaborator Author

jsa34 commented Nov 8, 2024

No rush at all - Appreciated as always!

src/pytest_bdd/parser.py Outdated Show resolved Hide resolved
@jsa34
Copy link
Collaborator Author

jsa34 commented Nov 12, 2024

Committed responses to latest feedback :)

src/pytest_bdd/parser.py Outdated Show resolved Hide resolved
@jsa34
Copy link
Collaborator Author

jsa34 commented Nov 12, 2024

Removed feature field from Rule

src/pytest_bdd/parser.py Outdated Show resolved Hide resolved
@jsa34
Copy link
Collaborator Author

jsa34 commented Nov 13, 2024

Feedback resolved :)

src/pytest_bdd/parser.py Outdated Show resolved Hide resolved
src/pytest_bdd/reporting.py Outdated Show resolved Hide resolved
@jsa34
Copy link
Collaborator Author

jsa34 commented Nov 13, 2024

Addressed feedback :)

youtux
youtux previously approved these changes Nov 13, 2024
@youtux youtux enabled auto-merge November 13, 2024 22:22
@jsa34 jsa34 mentioned this pull request Nov 13, 2024
# Conflicts:
#	CHANGES.rst
#	src/pytest_bdd/parser.py
#	src/pytest_bdd/scenario.py
@youtux youtux disabled auto-merge November 13, 2024 23:03
@jsa34
Copy link
Collaborator Author

jsa34 commented Nov 13, 2024

@youtux tried rerunning the checks, but codecov consistently seems unhappy. Not sure what's happening...

@youtux youtux enabled auto-merge November 13, 2024 23:07
@youtux youtux merged commit 8f9df7c into pytest-dev:master Nov 13, 2024
9 checks passed
@youtux
Copy link
Contributor

youtux commented Nov 13, 2024

Yeah there's something going on with codecov. I'll merge this manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule keyword
3 participants