Fix report template #804
Merged
Fix report template #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From djlint output: H005 2:0 Html tag should have lang attribute. <html> <head> H016 2:0 Missing title tag in html. <html> <head> H030 2:0 Consider adding a meta description. <html> <head> H031 2:0 Consider adding meta keywords. <html> <head> H006 48:20 Img tag should have height and width attributes. <img src="" /> H013 48:20 Img tag should have an alt attribute. <img src="" /> H025 87:112 Tag seems to be an orphan. </span> Linted 1 file, found 7 errors.
Removed extra `/` that caused reporting of next </span> tag
|
Nice! Thank you for this! |
|
@BeyondEvil Do we need something more to merge? |
Pierre-Sassoulas
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
My colleague had issues with displaying generated reports:
The report was correctly displayed on:
The report had no content or even showed blank page on:
When I checked the generated report file I noticed that:
Issues
Examples
pytest-html/src/pytest_html/resources/index.jinja2
Line 32 in 4b714aa
pytest-html/src/pytest_html/resources/index.jinja2
Line 51 in 4b714aa
Misc
This PR also adds
djlintto pre-commit hook.Changes
Fixed
Added