Drop python 3.8 support #12875

Pierre-Sassoulas · 2024-10-10T15:59:27Z

Closes #12874

RonnyPfannschmidt

Looks lovely at first glance

.github/workflows/test.yml

doc/en/backwards-compatibility.rst

.github/workflows/prepare-release-pr.yml

.github/workflows/test.yml

Pierre-Sassoulas · 2024-10-10T20:27:04Z

testing/code/test_excinfo.py

            if upframe.f_code.co_name == "_makepath":
                # Only raise with expected calls, but not via e.g. inspect for
-                # py38-windows.
+                # py38-windows. (?)
                raised += 1
                raise OSError(2, "custom_oserror")
            return orig_path_cwd()


Not sure what to do here, advise welcome

#6529 does not offer any explanation, however #6463 (comment) links it and implies that there might've been flakiness in the Codecov uploader. But this was like almost 5 years ago, and Codecov has since rewritten their uploader 3 times. We've additionally made it less flaky by hardcoding a plain-text token a few months ago.

Looking into the coverage reports, something weird is happening. The if-line is marked as covered partially, both in this PR and on main:

https://app.codecov.io/gh/pytest-dev/pytest/pull/12875/blob/testing/code/test_excinfo.py#L966

https://app.codecov.io/gh/pytest-dev/pytest/blob/main/testing%2Fcode%2Ftest_excinfo.py#L966

However, the return line is reported as 100% covered in the PR (https://app.codecov.io/gh/pytest-dev/pytest/pull/12875/blob/testing/code/test_excinfo.py#L971) while on main it's marked as not covered (https://app.codecov.io/gh/pytest-dev/pytest/blob/main/testing%2Fcode%2Ftest_excinfo.py#L966).

AFAIU, the raise instruction can only be reached on if True and the return statement would be reachable on if False. That should cover both branches of the if-block. So I don't understand why the conditional is marked with partial coverage.

_makepath() is also fully covered in both cases:

https://app.codecov.io/gh/pytest-dev/pytest/pull/12875/blob/src/_pytest/_code/code.py#L955

https://app.codecov.io/gh/pytest-dev/pytest/blob/main/src%2F_pytest%2F_code%2Fcode.py#L958

P.S. While looking into Codecov, I realized that it does not show any coverage for src/pytest/ — it's just not there. It looks like we also have Coveragepy misconfigured or something. Something to investigate.

I investigated a little, it was introduced in 79ae86c so that this function did not raise accidentally when inspecting on some env. So this is still useful as it's not only applicable for windows py38.

tox.ini

.github/workflows/test.yml

Pierre-Sassoulas · 2024-10-10T21:11:44Z

Changed the configuration of the repo so build (ubuntu-py38) and build (windows-py38) are not required anymore but 3.13 is. Two readthedoc warnings appeared related to sphinx_issues, not sure how to fix:

WARNING: while setting up extension sphinx_issues: role 'cve' is already registered, it will be overridden [app.add_role]
WARNING: while setting up extension sphinx_issues: role 'cwe' is already registered, it will be overridden [app.add_role]

.pre-commit-config.yaml

webknjaz · 2024-10-11T00:19:02Z

@Teri53 @TeriThetha please stop spamming.

webknjaz · 2024-10-11T00:24:44Z

@nicoddemus @RonnyPfannschmidt @The-Compiler can anybody ban the spammer, please?

webknjaz · 2024-10-11T00:33:13Z

🙄 c'mon...

nicoddemus · 2024-10-11T00:47:42Z

Blocked.

RonnyPfannschmidt

i like it !

the messy nature of the github matrix makes me wonder,
if we should investigate a script to generate it as a followup

its so easy to make mistakes in it, its scary

.github/workflows/test.yml

pytest-dev#12875 (comment)

Pierre-Sassoulas · 2024-10-12T21:40:02Z

The sphinx_issues warning was resolved magically in CI as well as locally, not sure how (I upgraded to latest ubuntu LTS / python 3.12.3), so only #12875 (comment) remains.

.github/workflows/test.yml

src/_pytest/capture.py

webknjaz · 2024-10-23T10:54:21Z

@Pierre-Sassoulas so I have all the files in this PR marked as reviewed except for src/_pytest/capture.py due to the 3.7 think I noticed. Not sure how far you'd want to go with addressing it, but everything LGTM otherwise.

Pierre-Sassoulas · 2024-10-29T15:24:15Z

Depends on #12910 (so we can activate pylint's consider-alternative-union-syntax and deprecated-typing-alias).

.github/workflows/test.yml

changelog/12874.breaking.rst

src/_pytest/config/argparsing.py

Pierre-Sassoulas · 2024-11-12T12:15:42Z

Fixing your other comment and reverting the bad fix, worked:

============================= test session starts =============================
platform win32 -- Python 3.10.11, pytest-8.4.0.dev159+gbd1faf745, pluggy-1.5.0

nicoddemus

Thanks, sorry for the delay!

Pierre-Sassoulas · 2024-11-18T22:50:02Z

No problem, it's a lot to review ! There was a conflict that I fixed, I'm going to clean up the history later on. (Or maybe we can squash everything ? Feels wrong though).

nicoddemus · 2024-11-18T22:58:11Z

Cleaning up the commit history here seems like a good idea.

Pierre-Sassoulas · 2024-11-19T08:30:27Z

4d3e7ae is bulky, but it's the only way to have each commit passing the tests suite (fixup of the pre-commit automated fixes and the CI/doc already reviewed changes)

nicoddemus · 2024-11-19T13:46:12Z

LGTM!

Pierre-Sassoulas · 2024-11-19T15:17:40Z

@RonnyPfannschmidt do you want to do a final review ?

bluetech

The changes look good to me, thanks for doing the work!

bluetech · 2024-11-19T21:54:27Z

src/_pytest/_code/code.py

@@ -10,6 +13,7 @@
 import os
 from pathlib import Path
 import re
+from re import Pattern


Feel free to ignore if it's a hassle: to me match: re.Pattern would be clearer than match: Pattern, so I'd drop the from re import Pattern and use it qualified instead. Same for re.Match.

bluetech · 2024-11-19T22:03:48Z

pyproject.toml

@@ -85,7 +84,7 @@ write_to = "src/_pytest/_version.py"

 [tool.black]
 target-version = [
-    'py38',
+    'py39',


Side note, according to https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#t-target-version, we don't need to configure this because black also looks at requires-python. It also says we're actually supposed to list all supported versions, oh well.

e2f17e0

Feel like I could have removed the option too there. I'm not sure if this option is useful since the example they gave in python 3.5. (Also black is only used in doc for blacken-docs afair)

…ntextManager'

nicoddemus · 2024-11-26T13:34:32Z

I believe it is OK to merge this, as there is a lot of approvals already, and these changes are a bother to maintain around given they can easily create conflicts. If anybody makes comments after the merge, we can always make a follow up. 👍

#12875 (comment)

nicoddemus · 2024-11-29T12:28:14Z

Awesome, thanks @Pierre-Sassoulas for tackling this!

RonnyPfannschmidt reviewed Oct 10, 2024

View reviewed changes

.github/workflows/test.yml Show resolved Hide resolved

Pierre-Sassoulas marked this pull request as draft October 10, 2024 16:31

nicoddemus reviewed Oct 10, 2024

View reviewed changes

doc/en/backwards-compatibility.rst Outdated Show resolved Hide resolved

nicoddemus reviewed Oct 10, 2024

View reviewed changes

.github/workflows/prepare-release-pr.yml Outdated Show resolved Hide resolved

Pierre-Sassoulas commented Oct 10, 2024

View reviewed changes

psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Oct 10, 2024

Pierre-Sassoulas force-pushed the drop-python3.8 branch from 14b36ce to 3f03eda Compare October 10, 2024 21:25

Pierre-Sassoulas marked this pull request as ready for review October 10, 2024 21:43

Pierre-Sassoulas changed the title ~~[Work in progress] Drop python 3.8 support~~ Drop python 3.8 support Oct 10, 2024

webknjaz reviewed Oct 10, 2024

View reviewed changes

.pre-commit-config.yaml Show resolved Hide resolved

Teri53 approved these changes Oct 10, 2024

View reviewed changes

RonnyPfannschmidt previously requested changes Oct 11, 2024

View reviewed changes

.github/workflows/test.yml Show resolved Hide resolved

Pierre-Sassoulas added a commit to Pierre-Sassoulas/pytest that referenced this pull request Oct 12, 2024

Apply comment from

b6e820f

pytest-dev#12875 (comment)

Pierre-Sassoulas commented Oct 12, 2024

View reviewed changes

.github/workflows/test.yml Show resolved Hide resolved

Pierre-Sassoulas force-pushed the drop-python3.8 branch from a01ec77 to c18279e Compare October 21, 2024 19:25

Pierre-Sassoulas modified the milestones: 8.2, 8.4 Oct 22, 2024

webknjaz reviewed Oct 23, 2024

View reviewed changes

src/_pytest/capture.py Outdated Show resolved Hide resolved

Pierre-Sassoulas force-pushed the drop-python3.8 branch from fbdfa47 to d876796 Compare October 29, 2024 15:24

nicoddemus mentioned this pull request Nov 8, 2024

pytest 8.4 release plans #12945

Open

Pierre-Sassoulas mentioned this pull request Nov 8, 2024

[pre-commit.ci] pre-commit autoupdate #12910

Merged

nicoddemus requested changes Nov 12, 2024

View reviewed changes

.github/workflows/test.yml Show resolved Hide resolved

nicoddemus reviewed Nov 12, 2024

View reviewed changes

changelog/12874.breaking.rst Outdated Show resolved Hide resolved

src/_pytest/config/argparsing.py Show resolved Hide resolved

Pierre-Sassoulas requested a review from nicoddemus November 12, 2024 22:03

nicoddemus approved these changes Nov 18, 2024

View reviewed changes

Pierre-Sassoulas force-pushed the drop-python3.8 branch from 1484446 to 3def6df Compare November 19, 2024 08:27

bluetech approved these changes Nov 19, 2024

View reviewed changes

mvoitko approved these changes Nov 25, 2024

View reviewed changes

Pierre-Sassoulas added 8 commits November 25, 2024 20:11

Upgrade doc and CI after dropping python 3.8

a4cb74e

Enable pylint's python 3.8 typing checks (deprecated-typing-alias)

05ed0d0

Remove code that is impossible to reach on python 3.9+

f57b26b

Fix 'typing.AbstractSet' is deprecated, use 'collections.abc.Set'

66fc31f

Fix 'typing.Type' is deprecated, use 'type' instead

e684e64

Fix 'typing.ContextManager' is deprecated, use 'contextlib.AbstractCo…

a6ef97b

…ntextManager'

[typing] Use the re namespace in 're' typing everywhere

1bacc00

[black] Fix the target-version configuration

58e2581

Pierre-Sassoulas force-pushed the drop-python3.8 branch from e2f17e0 to 58e2581 Compare November 25, 2024 19:12

nicoddemus mentioned this pull request Nov 26, 2024

[pre-commit.ci] pre-commit autoupdate #12995

Closed

[ruff] Set the target version to python 3.9

10c0c62

Pierre-Sassoulas merged commit b938e70 into pytest-dev:main Nov 28, 2024
28 checks passed

Pierre-Sassoulas deleted the drop-python3.8 branch November 28, 2024 20:26

Pierre-Sassoulas mentioned this pull request Nov 28, 2024

Upgrade ruff to 0.8.1 and fix existing issues #13009

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop python 3.8 support #12875

Drop python 3.8 support #12875

Pierre-Sassoulas commented Oct 10, 2024 •

edited

Loading

RonnyPfannschmidt left a comment

Pierre-Sassoulas Oct 10, 2024

webknjaz Oct 10, 2024 •

edited

Loading

Pierre-Sassoulas Oct 21, 2024

Pierre-Sassoulas commented Oct 10, 2024 •

edited

Loading

webknjaz commented Oct 11, 2024

webknjaz commented Oct 11, 2024

webknjaz commented Oct 11, 2024

nicoddemus commented Oct 11, 2024

RonnyPfannschmidt left a comment

Pierre-Sassoulas commented Oct 12, 2024 •

edited

Loading

webknjaz commented Oct 23, 2024

Pierre-Sassoulas commented Oct 29, 2024

Pierre-Sassoulas commented Nov 12, 2024

nicoddemus left a comment

Pierre-Sassoulas commented Nov 18, 2024

nicoddemus commented Nov 18, 2024

Pierre-Sassoulas commented Nov 19, 2024

nicoddemus commented Nov 19, 2024

Pierre-Sassoulas commented Nov 19, 2024

bluetech left a comment

bluetech Nov 19, 2024

Pierre-Sassoulas Nov 20, 2024

bluetech Nov 19, 2024

Pierre-Sassoulas Nov 20, 2024

nicoddemus commented Nov 26, 2024 •

edited

Loading

nicoddemus commented Nov 29, 2024

Drop python 3.8 support #12875

Drop python 3.8 support #12875

Conversation

Pierre-Sassoulas commented Oct 10, 2024 • edited Loading

RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

Pierre-Sassoulas Oct 10, 2024

Choose a reason for hiding this comment

webknjaz Oct 10, 2024 • edited Loading

Choose a reason for hiding this comment

Pierre-Sassoulas Oct 21, 2024

Choose a reason for hiding this comment

Pierre-Sassoulas commented Oct 10, 2024 • edited Loading

webknjaz commented Oct 11, 2024

webknjaz commented Oct 11, 2024

webknjaz commented Oct 11, 2024

nicoddemus commented Oct 11, 2024

RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

Pierre-Sassoulas commented Oct 12, 2024 • edited Loading

webknjaz commented Oct 23, 2024

Pierre-Sassoulas commented Oct 29, 2024

Pierre-Sassoulas commented Nov 12, 2024

nicoddemus left a comment

Choose a reason for hiding this comment

Pierre-Sassoulas commented Nov 18, 2024

nicoddemus commented Nov 18, 2024

Pierre-Sassoulas commented Nov 19, 2024

nicoddemus commented Nov 19, 2024

Pierre-Sassoulas commented Nov 19, 2024

bluetech left a comment

Choose a reason for hiding this comment

bluetech Nov 19, 2024

Choose a reason for hiding this comment

Pierre-Sassoulas Nov 20, 2024

Choose a reason for hiding this comment

bluetech Nov 19, 2024

Choose a reason for hiding this comment

Pierre-Sassoulas Nov 20, 2024

Choose a reason for hiding this comment

nicoddemus commented Nov 26, 2024 • edited Loading

nicoddemus commented Nov 29, 2024

Pierre-Sassoulas commented Oct 10, 2024 •

edited

Loading

webknjaz Oct 10, 2024 •

edited

Loading

Pierre-Sassoulas commented Oct 10, 2024 •

edited

Loading

Pierre-Sassoulas commented Oct 12, 2024 •

edited

Loading

nicoddemus commented Nov 26, 2024 •

edited

Loading