-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Math Library for Combining Pyth Prices on Solidity #1748
Closed
nirala-mehul
wants to merge
4
commits into
pyth-network:main
from
nirala-mehul:addPriceCombineLibrary
Closed
Add a Math Library for Combining Pyth Prices on Solidity #1748
nirala-mehul
wants to merge
4
commits into
pyth-network:main
from
nirala-mehul:addPriceCombineLibrary
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@nirala-mehul is attempting to deploy a commit to the pyth-web Team on Vercel. A member of the Team first needs to authorize it. |
anihamde
reviewed
Jul 4, 2024
PythStructs.Price memory right = mul(y1, frac2Q); | ||
// If resulting price is zero, return zero price | ||
if (right.price == 0) { | ||
return PythStructs.Price(0, 0, 0, 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
We have decided to move forward with #1746 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Price Library, a Solidity library comibing prices using
Price
data types. The library includes functions for basic arithmetic operations, normalization, scaling, and fraction calculations on Price structs.Changes Made
Summary of Public Functions Implemented in Price Library
Testing
Added a forge project and tests for PriceLibrary.