Allow connection_pool
to be set in RedisSettings
#473
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samuelcolvin
Thank you for a great library!
It would be really grateful if this PR could be reviewed or a workaround for this issue provided.
Many thanks.
We are using arq for our production app, and it appears that connection pool throws an error and
arq worker
crashes if the connection limit(max_connections
) is reached.Not only does worker but the
enqueue_job
method also throws an error under the same condition.This seems to be caused by the default
ConnectionPool
of redis-py.redis/redis-py#2517
Code to reproduce:
By allowing
connection_pool
to be set in RedisSettings, it seems to work as expected.It appears that
Worker
can takeredis_pool
as an argument, but I guess we can handle this case more concisely this way for bothWorker
andEnqueuer
, provided it does not break anything else.