-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Setting the PPM advection problem #157
Open
aisclark91
wants to merge
56
commits into
python-hydro:main
Choose a base branch
from
aisclark91:pr-134
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aisclark91
changed the title
[WIP] Setting the PPM advection problem 1
[WIP] Setting the PPM advection problem
Apr 14, 2023
aisclark91
changed the title
[WIP] Setting the PPM advection problem
Setting the PPM advection problem
Apr 16, 2023
aisclark91
changed the title
Setting the PPM advection problem
[WIP ]Setting the PPM advection problem
Apr 16, 2023
aisclark91
changed the title
[WIP ]Setting the PPM advection problem
Setting the PPM advection problem
Apr 17, 2023
aisclark91
changed the title
Setting the PPM advection problem
[WIP] Setting the PPM advection problem
Apr 21, 2023
This PR is ready for review. One changed proposed by @simonguichandut was to include the PPM as an option in the advection problem, leaving different folders for different time integration schemes. I want to follow this approach in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, implements:
Two more things remain:
simulation.py
and inherit as much as possible, and make soft links to the originaladvection
problem folder.