Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor bug fix in Rope autoimport plugin #464

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Minor bug fix in Rope autoimport plugin #464

merged 2 commits into from
Oct 18, 2023

Conversation

tkrabel-db
Copy link
Contributor

@tkrabel-db tkrabel-db commented Oct 17, 2023 •
edited by ccordoba12
Loading

Fix a little typo: The method should be called pylsp_workspace_configuration_changed, not pylsp_workspace_configuration_chaged

@ccordoba12 ccordoba12 mentioned this pull request Oct 17, 2023
Merged
2 tasks
@tkrabel-db tkrabel-db mentioned this pull request Oct 17, 2023
Merged
2 tasks
@ccordoba12 ccordoba12 changed the title Rope autoimport - minor bug fix Minor bug fix in Rope autoimport plugin Oct 18, 2023
@ccordoba12 ccordoba12 added the bug Something isn't working label Oct 18, 2023
@ccordoba12 ccordoba12 added this to the v1.9.0 milestone Oct 18, 2023
ccordoba12
ccordoba12 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tkrabel-db!

@ccordoba12 ccordoba12 merged commit 2f2c0e8 into python-lsp:develop Oct 18, 2023
10 checks passed
staticf0x pushed a commit to staticf0x/python-lsp-server that referenced this pull request Oct 27, 2023
@tkrabel-db @staticf0x
Minor bug fix in Rope autoimport plugin (python-lsp#464)
366d53d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tkrabel-db @ccordoba12