Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conceptual fix for issue #3589 #126

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conceptual fix for issue #3589 #126

wants to merge 5 commits into from

Commits on Jan 21, 2021

  1. Log all files being added

    @brechtm
    brechtm committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    beea7b4 View commit details
    Browse the repository at this point in the history

  2. Pass unresolved paths to is_excluded() 

    This makes is_excluded work with symlinks.
    @brechtm
    brechtm committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    275e5a4 View commit details
    Browse the repository at this point in the history

  3. 'exclude' should be able to override 'include' matches 

    Note that this behavior was different for files in dirs; see
"if file.is_dir():" block a bit higher in the code.

Related: python-poetry/poetry#1336
    @brechtm
    brechtm committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    26217e1 View commit details
    Browse the repository at this point in the history

  4. Some remarks

    @brechtm
    brechtm committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    77a4610 View commit details
    Browse the repository at this point in the history

  5. Exclude .git directories and files in them by default 

    Note that this makes a list of all files in .git directories and is
thus very slow.
    @brechtm
    brechtm committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    6585468 View commit details
    Browse the repository at this point in the history