Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to in-tree vendoring instead of patching the sys.path #753

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Secrus
Copy link
Member

@Secrus Secrus commented Aug 30, 2024

@dimbleby
Copy link
Contributor

Did you try running make vendor/update?

I expect that will reveal things you might have missed, and also give a hint as to whether the maintenance burden this brings is likely to be painful or not.

@abn
Copy link
Member

abn commented Nov 21, 2024

@Secrus I am not sure this is trivial to maintain long term. While the issue mentioned for plugins is not ideal, I get the distinct feeling that there are sufficient workarounds such that plugins could maintain the workarounds more easily than us having to carry the burden of maintaining this.

Just for reference the original discussion around this is at #25 (comment).

Note that this is before plugins were a thing.

@abn
Copy link
Member

abn commented Nov 21, 2024

Also, if I recall correctly, this change also was enabling downstream OS distro package maintainers to remove (or patch) vendor directories to re-package according to their requirements. This change will revert us back to a situation where they will have to start carrying patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry should not prepend sys.path with __vendor_site__
3 participants