Allow root package non-editable installation #5174
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Partially Resolves: #1382 (Implemented
--no-editable
for install command)If
--no-editable
flag is present, useSdistBuilder
as a builder, buildsetup.py
, then finally runpip_install
utility method without deps and without editable mode.I did some manual tests by trying to install back and forth with and without editable mode, which at first glance seems to work. However, after installing in editable mode again, the package directory (
.venv/lib/python3.x/site-packages/package_name
) seems still to exists but it's empty:It doesn't break the installation, but I just wanted to point that out. Lastly, the
*.pth
file is cleaned correctly.