Try finding commit using short SHA if it is not on HEAD

[mikhainin]

Pull Request Check List

If a dependency specifies a git revision using a short hash, Dulwich does not provide an option to directly address it (see discussion in #9560); however, we can still list revisions and find what we are looking for.

Resolves: #9560 #6455

• Added tests for changed code.
• Updated documentation for changed code.

[mikhainin]

It seemed to work in my case, but I would appreciate it if someone looked into this and told me if it makes sense.
Happy to add tests - I didn't find them for this functionality but my guess it should be somewhere in tests/vcs/git?

I can see some integration tests against https://github.com/python-poetry/test-fixture-vcs-repository but every commit there seems to have its own head/tag which does not allow to reproduce the initial issue...

[radoering]

@jelmer I'd appreciate if you could take a look if it makes sense (from a dulwich point of view).

[radoering]

Happy to add tests - I didn't find them for this functionality but my guess it should be somewhere in tests/vcs/git?

We have tests in tests/integration/test_utils_vcs_git.py and in main/tests/vcs/git/test_backend.py. Fast tests that do not require an external repository can be put into the latter.

I can see some integration tests against https://github.com/python-poetry/test-fixture-vcs-repository but every commit there seems to have its own head/tag which does not allow to reproduce the initial issue...

I have no idea if it is feasible, but maybe we can create a local repository in the test?

[jelmer]

Creating a local repository in e.g. a tempdir should be fast and easy with Dulwich - Repo.init(path) will do what you need.

[mikhainin]

I added the test, I had to introduce a new marker "skip_git_mock" not to mock "git clone" as that one is not ready to mock local clone.

The rest was copied from tests/vcs/git/test_system.py: I moved fixtures into separate files so they can be re-used and added a "middle commit" so the issue was finally reproduced.

[jelmer]

I added the test, I had to introduce a new marker "skip_git_mock" not to mock "git clone" as that one is not ready to mock local clone.

The rest was copied from tests/vcs/git/test_system.py: I moved fixtures into separate files so they can be re-used and added a "middle commit" so the issue was finally reproduced.

LGTM, for what it's worth.

[abn]

This will likely also require #9849 if we intend to update dulwich.

[dimbleby]

This will likely also require #9849 if we intend to update dulwich.

Since recent dulwich releases are bumping only the patch number, poetry users are already getting the latest dulwich.

Are you saying that dulwich has released a breaking change in a patch release?

Edit the poetry 1.8 branch is still on the dulwich 0.21 series, so I am wrong about poetry users already getting the latest.

Nevertheless #9849 says it was fixing something from "dulwich >=0.22.2" so the question stands

[jelmer]

I'm curious what change is, we haven't had reports of API breakages.

[abn]

@jelmer To close the loop regarding @dimbleby 's question; I have raised a dulwich issue for triage with a reproducer.

Cross-post: jelmer/dulwich#1443