Skip to content

Commit

Permalink
[3.13] gh-101525: Skip test_gdb if the binary is relocated by BOLT. (g…
Browse files Browse the repository at this point in the history
…h-118572) (#123601)

gh-101525: Skip test_gdb if the binary is relocated by BOLT. (gh-118572)
(cherry picked from commit f95fc4d)

Co-authored-by: Donghee Na <[email protected]>
  • Loading branch information
miss-islington and corona10 authored Sep 2, 2024
1 parent 05dcc81 commit 3b3a1a8
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 0 deletions.
5 changes: 5 additions & 0 deletions Lib/test/libregrtest/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,11 @@ def get_build_info():
if support.check_cflags_pgo():
# PGO (--enable-optimizations)
optimizations.append('PGO')

if support.check_bolt_optimized():
# BOLT (--enable-bolt)
optimizations.append('BOLT')

if optimizations:
build.append('+'.join(optimizations))

Expand Down
9 changes: 9 additions & 0 deletions Lib/test/support/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -866,6 +866,15 @@ def check_cflags_pgo():
return any(option in cflags_nodist for option in pgo_options)


def check_bolt_optimized():
# Always return false, if the platform is WASI,
# because BOLT optimization does not support WASM binary.
if is_wasi:
return False
config_args = sysconfig.get_config_var('CONFIG_ARGS') or ''
return '--enable-bolt' in config_args


Py_GIL_DISABLED = bool(sysconfig.get_config_var('Py_GIL_DISABLED'))

def requires_gil_enabled(msg="needs the GIL enabled"):
Expand Down
3 changes: 3 additions & 0 deletions Lib/test/test_gdb/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@
if support.check_cflags_pgo():
raise unittest.SkipTest("test_gdb is not reliable on PGO builds")

if support.check_bolt_optimized():
raise unittest.SkipTest("test_gdb is not reliable on BOLT optimized builds")


def load_tests(*args):
return support.load_package_tests(os.path.dirname(__file__), *args)
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Skip ``test_gdb`` if the binary is relocated by BOLT.
Patch by Donghee Na.

0 comments on commit 3b3a1a8

Please sign in to comment.