Skip to content

Commit

Permalink
[3.12] gh-119727: Add --single-process option to regrtest (GH-119728) (
Browse files Browse the repository at this point in the history
…#130359)

Co-authored-by: Victor Stinner <[email protected]>
  • Loading branch information
hugovk and vstinner authored Feb 20, 2025
1 parent 60410f3 commit ecfca20
Show file tree
Hide file tree
Showing 4 changed files with 43 additions and 9 deletions.
11 changes: 11 additions & 0 deletions Lib/test/libregrtest/cmdline.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ def __init__(self, **kwargs) -> None:
self.tempdir = None
self._add_python_opts = True
self.xmlpath = None
self.single_process = False

super().__init__(**kwargs)

Expand Down Expand Up @@ -307,6 +308,12 @@ def _create_parser():
group.add_argument('-j', '--multiprocess', metavar='PROCESSES',
dest='use_mp', type=int,
help='run PROCESSES processes at once')
group.add_argument('--single-process', action='store_true',
dest='single_process',
help='always run all tests sequentially in '
'a single process, ignore -jN option, '
'and failed tests are also rerun sequentially '
'in the same process')
group.add_argument('-T', '--coverage', action='store_true',
dest='trace',
help='turn on code coverage tracing using the trace '
Expand Down Expand Up @@ -436,6 +443,10 @@ def _parse_args(args, **kwargs):
else:
ns._add_python_opts = False

# --singleprocess overrides -jN option
if ns.single_process:
ns.use_mp = None

# When both --slow-ci and --fast-ci options are present,
# --slow-ci has the priority
if ns.slow_ci:
Expand Down
26 changes: 17 additions & 9 deletions Lib/test/libregrtest/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,13 @@ def __init__(self, ns: Namespace, _add_python_opts: bool = False):
self.cmdline_args: TestList = ns.args

# Workers
if ns.use_mp is None:
num_workers = 0 # run sequentially
self.single_process: bool = ns.single_process
if self.single_process or ns.use_mp is None:
num_workers = 0 # run sequentially in a single process
elif ns.use_mp <= 0:
num_workers = -1 # use the number of CPUs
num_workers = -1 # run in parallel, use the number of CPUs
else:
num_workers = ns.use_mp
num_workers = ns.use_mp # run in parallel
self.num_workers: int = num_workers
self.worker_json: StrJSON | None = ns.worker_json

Expand Down Expand Up @@ -234,7 +235,7 @@ def list_tests(tests: TestTuple):

def _rerun_failed_tests(self, runtests: RunTests):
# Configure the runner to re-run tests
if self.num_workers == 0:
if self.num_workers == 0 and not self.single_process:
# Always run tests in fresh processes to have more deterministic
# initial state. Don't re-run tests in parallel but limit to a
# single worker process to have side effects (on the system load
Expand All @@ -244,7 +245,6 @@ def _rerun_failed_tests(self, runtests: RunTests):
tests, match_tests_dict = self.results.prepare_rerun()

# Re-run failed tests
self.log(f"Re-running {len(tests)} failed tests in verbose mode in subprocesses")
runtests = runtests.copy(
tests=tests,
rerun=True,
Expand All @@ -254,7 +254,15 @@ def _rerun_failed_tests(self, runtests: RunTests):
match_tests_dict=match_tests_dict,
output_on_failure=False)
self.logger.set_tests(runtests)
self._run_tests_mp(runtests, self.num_workers)

msg = f"Re-running {len(tests)} failed tests in verbose mode"
if not self.single_process:
msg = f"{msg} in subprocesses"
self.log(msg)
self._run_tests_mp(runtests, self.num_workers)
else:
self.log(msg)
self.run_tests_sequentially(runtests)
return runtests

def rerun_failed_tests(self, runtests: RunTests):
Expand Down Expand Up @@ -367,7 +375,7 @@ def run_tests_sequentially(self, runtests):
tests = count(jobs, 'test')
else:
tests = 'tests'
msg = f"Run {tests} sequentially"
msg = f"Run {tests} sequentially in a single process"
if runtests.timeout:
msg += " (timeout: %s)" % format_duration(runtests.timeout)
self.log(msg)
Expand Down Expand Up @@ -589,7 +597,7 @@ def _add_cross_compile_opts(self, regrtest_opts):
keep_environ = True

if cross_compile and hostrunner:
if self.num_workers == 0:
if self.num_workers == 0 and not self.single_process:
# For now use only two cores for cross-compiled builds;
# hostrunner can be expensive.
regrtest_opts.extend(['-j', '2'])
Expand Down
13 changes: 13 additions & 0 deletions Lib/test/test_regrtest.py
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,19 @@ def test_verbose3_huntrleaks(self):
self.assertEqual(regrtest.hunt_refleak.runs, 10)
self.assertFalse(regrtest.output_on_failure)

def test_single_process(self):
args = ['-j2', '--single-process']
with support.captured_stderr():
regrtest = self.create_regrtest(args)
self.assertEqual(regrtest.num_workers, 0)
self.assertTrue(regrtest.single_process)

args = ['--fast-ci', '--single-process']
with support.captured_stderr():
regrtest = self.create_regrtest(args)
self.assertEqual(regrtest.num_workers, 0)
self.assertTrue(regrtest.single_process)


@dataclasses.dataclass(slots=True)
class Rerun:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Add ``--single-process`` command line option to Python test runner (regrtest).
Patch by Victor Stinner.

0 comments on commit ecfca20

Please sign in to comment.