Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for dis command-line interface #127637

Open
picnixz opened this issue Dec 5, 2024 · 1 comment
Open

Add tests for dis command-line interface #127637

picnixz opened this issue Dec 5, 2024 · 1 comment
Assignees
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes tests Tests in the Lib/test dir

Comments

@picnixz
Copy link
Contributor

picnixz commented Dec 5, 2024

The dis CLI (added in 3.10 or so) is lacking tests. I'll be writing them tomorrow or tonight, depending on when I'm done with my IRL tasks.

I think we can backport tests for all command-line options that were introduced in previous versions (up to 3.12) and only write tests for those that were introduced in 3.14 (namely --show-positions (#123168) and --specialized (#127414), and maybe more, but those I've added those two so I know they are 3.14+). To that end, I'll write two separate PRs so to ease backports.

cc @iritkatriel

Linked PRs

@picnixz picnixz added tests Tests in the Lib/test dir 3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes labels Dec 5, 2024
@picnixz picnixz self-assigned this Dec 5, 2024
@mdboom mdboom added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Dec 5, 2024
@picnixz picnixz removed the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Dec 5, 2024
@picnixz
Copy link
Contributor Author

picnixz commented Dec 5, 2024

(Removing the interpreter-core label because it will only affect the Lib/test directory and not others)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes tests Tests in the Lib/test dir
Projects
None yet
Development

No branches or pull requests

2 participants