New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-127637: add tests for `dis` command-line interface #127759

Merged

iritkatriel merged 5 commits into python:main from picnixz:test/dis/127637

Dec 9, 2024

Contributor

picnixz commented Dec 9, 2024 •

edited

Loading

We can decide to backport it or not.

Issue: Add tests for dis command-line interface #127637

picnixz added 2 commits

December 9, 2024 12:29


          add tests for dis command-line interface

bd6af2c


          blurb

a240b81

picnixz requested a review from iritkatriel

December 9, 2024 11:36

bedevere-app bot added the awaiting review label

bedevere-app bot mentioned this pull request

Add tests for dis command-line interface #127637

Open

iritkatriel reviewed

View reviewed changes

Lib/test/test_dis.py Outdated Show resolved Hide resolved

iritkatriel reviewed

View reviewed changes

Lib/test/test_dis.py Outdated Show resolved Hide resolved


          address Irit's review

d277814

picnixz requested a review from iritkatriel

December 9, 2024 15:03

iritkatriel reviewed

View reviewed changes

Lib/test/test_dis.py Outdated Show resolved Hide resolved

iritkatriel reviewed

View reviewed changes

Lib/test/test_dis.py Outdated Show resolved Hide resolved


          address Irit's review (round 2)

c2a0b43

iritkatriel reviewed

View reviewed changes

Lib/test/test_dis.py Outdated Show resolved Hide resolved

Lib/test/test_dis.py Show resolved Hide resolved


          add test for unknown option

ca68f3b

iritkatriel reviewed

View reviewed changes

Lib/test/test_dis.py Show resolved Hide resolved

Member

iritkatriel commented Dec 9, 2024

We can decide to backport it or not.

We can backport, but I think it would need manual intervention to remove the new option you added last week.

iritkatriel added needs backport to 3.12 needs backport to 3.13 labels

Contributor Author

picnixz commented Dec 9, 2024

We can backport, but I think it would need manual intervention to remove the new option you added last week.

Yes. But I wondered whether you wanted a NEWS entry as well in the backports (I didn't think of it before...)

Contributor Author

picnixz commented Dec 9, 2024

Since I would anyway need a manual backport (otherwise, the tests will fail and it will be harder to edit the PR), I'll remove the backports labels and will make them myself afterwards.

picnixz removed needs backport to 3.12 needs backport to 3.13 labels

Member

iritkatriel commented Dec 9, 2024

We can backport, but I think it would need manual intervention to remove the new option you added last week.

Yes. But I wondered whether you wanted a NEWS entry as well in the backports (I didn't think of it before...)

The new entry doesn't need to change right?

We don't need this in what's new in.. because it's not user facing.

iritkatriel approved these changes

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels

iritkatriel merged commit e85f2f1 into python:main

50 checks passed

bedevere-app bot removed the awaiting merge label

iritkatriel added tests awaiting merge labels

picnixz deleted the test/dis/127637 branch

December 9, 2024 18:05

Contributor Author

picnixz commented Dec 9, 2024

I'll do the backports tomorrow.

picnixz added a commit to picnixz/cpython that referenced this pull request


          pythongh-127637: add tests for dis command-line interface (python#1…

0b929a7

…27759)

bedevere-app bot commented Dec 10, 2024

GH-127780 is a backport of this pull request to the 3.12 branch.

picnixz added a commit to picnixz/cpython that referenced this pull request


          pythongh-127637: add tests for dis command-line interface (python#1…

8d55075

…27759)

bedevere-app bot commented Dec 10, 2024

GH-127781 is a backport of this pull request to the 3.13 branch.

picnixz added a commit to picnixz/cpython that referenced this pull request


          pythongh-127637: add tests for dis command-line interface (python#1…

eb3ad0f

…27759)

picnixz added a commit to picnixz/cpython that referenced this pull request


          pythongh-127637: add tests for dis command-line interface (python#1…

2d880a1

…27759)

iritkatriel pushed a commit that referenced this pull request


          [3.13] gh-127637: add tests for dis command-line interface (#127759) (

8bf5b89

#127781)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge tests