Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Backport test_cext and test_cppext (C API tests) from main to the 3.12 branch #127906

Closed
vstinner opened this issue Dec 13, 2024 · 3 comments
Closed

[tests] Backport test_cext and test_cppext (C API tests) from main to the 3.12 branch #127906

vstinner opened this issue Dec 13, 2024 · 3 comments
Labels
tests Tests in the Lib/test dir topic-C-API

Comments

@vstinner
Copy link
Member

vstinner commented Dec 13, 2024 •
edited by bedevere-app bot
Loading

The C API is not well tested in the 3.12 branch. I propose to backport test_cext and test_cppext from the main branch to the 3.12 branch.

Example of recent C++ regression: #127902

Linked PRs
@vstinner vstinner added tests Tests in the Lib/test dir topic-C-API labels Dec 13, 2024
@vstinner vstinner mentioned this issue Dec 13, 2024
Closed
@vstinner
Copy link
Member Author

On the 3.12 branch, test_cext currently fails with these warnings:

  C:\victor\python\3.12\include\cpython/unicodeobject.h(205): error C2220: the following warning is treated as an error
  C:\victor\python\3.12\include\cpython/unicodeobject.h(205): warning C4100: '_unused_op': unreferenced formal parameter
  C:\victor\python\3.12\include\cpython/unicodeobject.h(395): warning C4100: '_unused_op': unreferenced formal parameter
  C:\victor\python\3.12\include\cpython/pytime.h(192): warning C4115: 'timeval': named type definition in parentheses
  extension.c(22): warning C4100: '_unused_module': unreferenced formal parameter
  extension.c(44): warning C4100: '_unused_module': unreferenced formal parameter

I backported MSVC support in Py_UNUSED() to 3.12 to fix unicodeobject.h: PR gh-127907.

@vstinner vstinner mentioned this issue Dec 13, 2024
Merged
@bedevere-app bedevere-app bot mentioned this issue Dec 13, 2024
Merged
@vstinner
Copy link
Member Author

C:\victor\python\3.12\include\cpython/pytime.h(192): warning C4115: 'timeval': named type definition in parentheses

I wrote #127908 to fix this pytime.h warning.

vstinner added a commit that referenced this issue Dec 13, 2024
@vstinner
[3.12] gh-127906: Declare timeval struct in pytime.h on Windows (#127908
c77bfd7 
)

gh-127906: Declare timeval struct in pytime.h on Windows

Fix the following MSVC compiler warning:

    include\cpython\pytime.h(192): warning C4115: 'timeval':
    named type definition in parentheses
vstinner added a commit to vstinner/cpython that referenced this issue Dec 13, 2024
@vstinner
pythongh-127906: Backport test_cext from the main branch
7aeb445
@bedevere-app bedevere-app bot mentioned this issue Dec 13, 2024
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Dec 13, 2024
@vstinner
pythongh-127906: Backport test_cppext changes from main
48660d5
@bedevere-app bedevere-app bot mentioned this issue Dec 13, 2024
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Dec 13, 2024
@vstinner
pythongh-127906: Update test_cppext from the main branch
269228d
vstinner added a commit to vstinner/cpython that referenced this issue Dec 13, 2024
@vstinner
pythongh-127906: Backport test_cppext from the main branch
d80dae7
@bedevere-app bedevere-app bot mentioned this issue Dec 13, 2024
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Dec 13, 2024
@vstinner
pythongh-127906: Test the limited C API in test_cppext
03d29cd
vstinner added a commit to vstinner/cpython that referenced this issue Dec 13, 2024
@vstinner
pythongh-127906: Test the limited C API in test_cppext
c95b2d1
@bedevere-app bedevere-app bot mentioned this issue Dec 13, 2024
Merged
vstinner added a commit that referenced this issue Dec 13, 2024
@vstinner
[3.12] gh-127906: Backport test_cppext changes from the main branch (#…
6544f99 
…127915)
vstinner added a commit that referenced this issue Dec 13, 2024
@vstinner
[3.13] gh-127906: Backport test_cppext changes from the main branch (#…
b620e50 
…127914)
vstinner added a commit to vstinner/cpython that referenced this issue Dec 13, 2024
@vstinner
pythongh-127906: Test the limited C API in test_cppext
79b2f66
vstinner added a commit that referenced this issue Dec 13, 2024
@vstinner
gh-127906: Test the limited C API in test_cppext (#127916)
d05a4e6
vstinner added a commit that referenced this issue Dec 13, 2024
@vstinner
[3.12] gh-127906: Backport test_cext from the main branch (#127912)
5a658d8
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Dec 13, 2024
@vstinner @miss-islington
pythongh-127906: Test the limited C API in test_cppext (pythonGH-127916)
e1acb12 
(cherry picked from commit d05a4e6)

Co-authored-by: Victor Stinner <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Dec 13, 2024
@vstinner @miss-islington
pythongh-127906: Test the limited C API in test_cppext (pythonGH-127916)
5e35a7b 
(cherry picked from commit d05a4e6)

Co-authored-by: Victor Stinner <[email protected]>
This was referenced Dec 13, 2024
Merged
Merged
vstinner added a commit that referenced this issue Dec 13, 2024
@miss-islington @vstinner
[3.13] gh-127906: Test the limited C API in test_cppext (GH-127916) (#…
78095c9 
…127919)

gh-127906: Test the limited C API in test_cppext (GH-127916)
(cherry picked from commit d05a4e6)

Co-authored-by: Victor Stinner <[email protected]>
vstinner added a commit that referenced this issue Dec 13, 2024
@miss-islington @vstinner
[3.12] gh-127906: Test the limited C API in test_cppext (GH-127916) (#…
58916eb 
…127920)

gh-127906: Test the limited C API in test_cppext (GH-127916)
(cherry picked from commit d05a4e6)

Co-authored-by: Victor Stinner <[email protected]>
vstinner added a commit to vstinner/cpython that referenced this issue Dec 13, 2024
@vstinner
pythongh-127906: Backport test_cext changes from the main branch
5950829
@bedevere-app bedevere-app bot mentioned this issue Dec 13, 2024
Merged
vstinner added a commit that referenced this issue Dec 13, 2024
@vstinner
[3.13] gh-127906: Backport test_cext changes from the main branch (#1…
2996a2b 
…27923)
@vstinner
Copy link
Member Author

I tested manually: with "[3.12] gh-127906: Test the limited C API in test_cppext", test_cppext is able to catch #127902 regression!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir topic-C-API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vstinner