Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.12] gh-127906: Declare timeval struct in pytime.h on Windows #127908

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Dec 13, 2024

Fix the following MSVC compiler warning:

include\cpython\pytime.h(192): warning C4115: 'timeval':
named type definition in parentheses

Fix the following MSVC compiler warning:

    include\cpython\pytime.h(192): warning C4115: 'timeval':
    named type definition in parentheses
@vstinner
Copy link
Member Author

Note: the existing struct timeval code was added for clang by commit 737d367:

+#ifdef __clang__
+struct timeval;
+#endif
commit 737d367b1f4bad76914173a64d6bbe19a984cd5f
Author: Steve Dower <[email protected]>
Date:   Fri Jan 27 14:45:08 2023 +0000

    gh-77532: Minor tweaks to allow compiling with PlatformToolset=ClangCL on Windows (GH-101352)
    
    To use this, ensure that clang support was selected in Visual Studio Installer, then set the PlatformToolset environment variable to "ClangCL" and build as normal from the command line.
    It remains unsupported, but at least is possible now for experimentation.

@vstinner vstinner enabled auto-merge (squash) December 13, 2024 12:07
@vstinner vstinner merged commit c77bfd7 into python:3.12 Dec 13, 2024
29 checks passed
@vstinner vstinner deleted the pytime12 branch December 13, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant