gh-117657: Skip tests that use threads after fork #122194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colesbury
added
tests
colesbury
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
colesbury
changed the title
These tests fail when run under thread sanitizer due to the use of fork and threads..
colesbury
force-pushed
the
gh-122187-asyncio-threads-fork
branch
from
f9cfafe to
f67f383
Compare
|
Oops, I had the wrong issue number originally. It should be #117657. |
willingc
approved these changes
Jul 23, 2024
|
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 23, 2024
) These tests fail when run under thread sanitizer due to the use of fork and threads. (cherry picked from commit 64e221d) Co-authored-by: Sam Gross <[email protected]>
|
GH-122198 is a backport of this pull request to the 3.13 branch. |
colesbury
added a commit
that referenced
this pull request
Jul 23, 2024
…122198) These tests fail when run under thread sanitizer due to the use of fork and threads. (cherry picked from commit 64e221d) Co-authored-by: Sam Gross <[email protected]>
nohlson
pushed a commit
to nohlson/cpython
that referenced
this pull request
Jul 24, 2024
These tests fail when run under thread sanitizer due to the use of fork and threads.
nohlson
pushed a commit
to nohlson/cpython
that referenced
this pull request
Jul 24, 2024
These tests fail when run under thread sanitizer due to the use of fork and threads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests fail when run under thread sanitizer due to the use of fork and threads.