-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-115999: Introduce helpers for (un)specializing instructions #126414
Conversation
Consolidate the code to specialize/unspecialize instructions into two helper functions and use them in `_Py_Specialize_BinaryOp`. The resulting code is more concise and keeps all of the logic at the point where we decide to specialize/unspecialize an instruction. If folks are amenable to this change, we can incrementally introduce their use as we work through making each specialization family thread-safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Not sure what is going on here, but this has caused a mass failure of buildbots... I'm seeing it on the iOS buildbot, where it's failing to build the macOS host build, before it even gets to the iOS build:
|
@freakboy3742 - it's fixed in main now (by @Eclips4) |
Sorry this was my fault. I merged this after #126450 was merged, without merging main into this PR first. This should be fixed by #126517. |
…ython#126414) Introduce helpers for (un)specializing instructions Consolidate the code to specialize/unspecialize instructions into two helper functions and use them in `_Py_Specialize_BinaryOp`. The resulting code is more concise and keeps all of the logic at the point where we decide to specialize/unspecialize an instruction.
Consolidate the code to specialize/unspecialize instructions into two helper functions and use them in
_Py_Specialize_BinaryOp
. The result is more concise and keeps all of the logic at the point where we decide to specialize/unspecialize an instruction.If folks are amenable to this change, we can incrementally introduce their use as we work through making each specialization family thread-safe.
--disable-gil
builds #115999