Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-115999: Move specializer test from test_dis to test_opcache #126498

Merged
merged 3 commits into from
Nov 6, 2024
Merged

gh-115999: Move specializer test from test_dis to test_opcache #126498

merged 3 commits into from
Nov 6, 2024

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Nov 6, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels Nov 6, 2024
@bedevere-app bedevere-app bot mentioned this pull request Nov 6, 2024
Open
@corona10 corona10 changed the title gh-115999: Move specialier test to test_opcache gh-115999: Move specializer test to test_opcache Nov 6, 2024
@corona10 corona10 changed the title gh-115999: Move specializer test to test_opcache gh-115999: Move specializer test from test_dis to test_opcache Nov 6, 2024
@corona10
Copy link
Member Author

corona10 commented Nov 6, 2024

Motivation: #126450 (comment)

@corona10 corona10 mentioned this pull request Nov 6, 2024
Open
corona10
corona10 commented Nov 6, 2024
View reviewed changes
Lib/test/test_opcache.py
self.assertFalse(3 in b)

f()
self.assert_specialized(f, "CONTAINS_OP_DICT")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, if the opcodes become more complex, we may need to count how many specific opcodes have occurred.

markshannon
markshannon approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

We have a lot of tests in test_dis that need to be moved elsewhere. Every test moved helps.

mpage
mpage approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@mpage mpage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@corona10 corona10 merged commit e56fd44 into python:main Nov 6, 2024
38 checks passed
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@corona10 @picnixz
pythongh-115999: Move specializer test from test_dis to test_opcache (p…
393f5b5 
…ythongh-126498)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon markshannon approved these changes

@mpage mpage mpage approved these changes

@Yhg1s Yhg1s Awaiting requested review from Yhg1s

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corona10 @mpage @markshannon