Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-126332: Fix pyrepl crash for double ctrl-z in line overflow #126650

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gh-126332: Fix pyrepl crash for double ctrl-z in line overflow #126650

wants to merge 3 commits into from
+16 −1

Conversation

eendebakpt
Copy link
Contributor

@eendebakpt eendebakpt commented Nov 10, 2024 •
edited by bedevere-app bot
Loading

Notes:

  • Fix crash of pyrepl in windows when a double ctrl-z is entered on an overflowing line.
  • The fix can also be put into the str_width method instead of the wlen method. Both of these are not documented, so I am not sure whether one location should be preferred over the other.

@bedevere-app bedevere-app bot mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eendebakpt