Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-129989: Properly disable tailcall interp in configure #129991

Merged
merged 7 commits into from
Feb 15, 2025
Merged

gh-129989: Properly disable tailcall interp in configure #129991

merged 7 commits into from
Feb 15, 2025
+287 −286

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Feb 11, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 11, 2025
Closed
@corona10
Copy link
Member

cpython/Python/ceval.c

Line 793 in 05e89c3

#if USE_COMPUTED_GOTOS && !defined(Py_TAIL_CALL_INTERP)

No need to change this line too?

@Fidget-Spinner
Copy link
Member Author

Oh good catch. Thanks!

@Fidget-Spinner Fidget-Spinner merged commit 359c7dd into python:main Feb 15, 2025
71 checks passed
@Fidget-Spinner Fidget-Spinner deleted the properly_disable branch February 15, 2025 19:01
@Fidget-Spinner
Copy link
Member Author

Thanks Zanie for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@corona10 corona10 Awaiting requested review from corona10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fidget-Spinner @corona10 @zanieb