-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-46236: Document PyUnicode_RSplit, PyUnicode_Partition and PyUnicode_RPartition #130191
Conversation
…Unicode_RPartition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've never sent my review...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do a follow-up for normalizing all the naming and check if we need to be pedantic with string vs Unicode string (it may matter as it could hint about the most general kind of the Unicode object).
EDIT: Fine to leave the lonely cases as they are unless someone has time to fix those kind of typos. Though it's possibly better to simply add a top-level paragraph saying "Unless stated otherwise, the terminology "string" refers to a Unicode string" (and not just ASCII-only string).
Misc/NEWS.d/next/Documentation/2025-02-16-14-57-00.gh-issue-46236.2HuS4S.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AFAIK that's a holdover from Python 2, where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two more items I'd like to see in new docs:
Co-authored-by: Petr Viktorin <[email protected]>
…Unicode_RPartition (pythonGH-130191) (cherry picked from commit 0f5b821) Co-authored-by: Marc Mueller <[email protected]> Co-authored-by: Petr Viktorin <[email protected]>
GH-130360 is a backport of this pull request to the 3.13 branch. |
…Unicode_RPartition (pythonGH-130191) (cherry picked from commit 0f5b821) Co-authored-by: Marc Mueller <[email protected]> Co-authored-by: Petr Viktorin <[email protected]>
GH-130361 is a backport of this pull request to the 3.12 branch. |
Merged, thank you @cdce8p. |
…yUnicode_RPartition (GH-130191) (#130360) gh-46236: Document PyUnicode_RSplit, PyUnicode_Partition and PyUnicode_RPartition (GH-130191) (cherry picked from commit 0f5b821) Co-authored-by: Marc Mueller <[email protected]> Co-authored-by: Petr Viktorin <[email protected]>
…yUnicode_RPartition (GH-130191) (#130361) gh-46236: Document PyUnicode_RSplit, PyUnicode_Partition and PyUnicode_RPartition (GH-130191) (cherry picked from commit 0f5b821) Co-authored-by: Marc Mueller <[email protected]> Co-authored-by: Petr Viktorin <[email protected]>
📚 Documentation preview 📚: https://cpython-previews--130191.org.readthedocs.build/