prepare for pypy3.11 release #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattip
commented
Nov 18, 2024
| @@ -13,7 +13,6 @@ | |||
| import argparse | |||
| import os.path | |||
| import shutil | |||
| import subprocess | |||
mattip
commented
Nov 18, 2024
tests/test_pythoncapi_compat.py
Outdated
| @@ -62,7 +62,7 @@ def build_ext(): | |||
| display_title("Build test extensions") | |||
| if os.path.exists("build"): | |||
| shutil.rmtree("build") | |||
| cmd = [sys.executable, "setup.py", "build"] | |||
| cmd = [sys.executable, "setup.py", "build", "--debug"] | |||
There was a problem hiding this comment.
although runtests.py runs tests in a subprocess, I could debug my segfaults by running
gdb --args pypy3.11 tests/test_pythoncapi_compat.py -v
Using a debug build makes it easier
|
Is the windows 3.6 debug failure on me? I don't think it is related... |
vstinner
reviewed
Nov 19, 2024
|
Merged, thanks. Please create a separated PR to add |
|
Thanks!. I will use |
Ok, I'm also fine with that :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are working on PyPy3.11. It requires some adjustments here:
PyThreadState_GetInterpreterandPyGC_Collect._PyObject_GetDictPtrreturnsNULLon PyPy. That is probably a bug. In any case, the test should not segfault by dereferencing a NULL pointer so I added a check.