Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark python-crontab as completed #8938

Merged
merged 3 commits into from
Oct 20, 2022
Merged

Conversation

sobolevn
Copy link
Member

It was just added in #8917

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@sobolevn
Copy link
Member Author

I will try to check for possible stubtest changes to fix constants re-export.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@AlexWaygood AlexWaygood merged commit 79d3312 into python:master Oct 20, 2022
@AlexWaygood
Copy link
Member

AlexWaygood commented Oct 20, 2022

I will try to check for possible stubtest changes to fix constants re-export.

You could potentially try to get the source code of the runtime module with inspect.getsource(), and then do AST analysis to examine which symbols are exported from other modules.

@sobolevn
Copy link
Member Author

This is quite complex, I am thinking about some importlib magic for now 🤔

@AlexWaygood
Copy link
Member

Give me a ping if you want a hand/second look on anything :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants