Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LA: scalars, vectors, dot product, bases #68

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

j-m-dean
Copy link
Contributor

Thinking this may have to be a stand alone chapter...

Comments and suggestions would be appreciated on what is written so far. There probably needs to be some fleshing out and more detailed explanations but not sure where.

@j-m-dean j-m-dean requested review from arm61 and alexsquires May 26, 2020 20:55
@arm61
Copy link
Contributor

arm61 commented Jun 10, 2020

Sorry for the delay. Work...eh!?

Comments:

  • "wide bearing" is weird language to me...
  • Love this "we believe that gaining knowledge about these fundamental concepts will not only allow you to become a better programmer, but allow you to tackle the more difficult chemistry problems as well." I wanna get this tattooed on me
  • What is theta in the first equation? Explain what each value in the equation is.
  • "Now image" -> "Now imagine" (I assume)
  • Increase transparency on the sphere
  • Perhaps "The Dot product of vectors" to "Some definitions"?
  • Use {:.2f} instead of np.round, if you are doing what I think you are
  • "\mathbf{r} = x \mathbf{i} + y \mathbf{j} + z \mathbf{z}" -> "\mathbf{r} = x \mathbf{i} + y \mathbf{j} + z \mathbf{k}"
  • rogue $ in "cannot write the vector..."
  • missing a "your code here" cell at the bottom

@arm61
Copy link
Contributor

arm61 commented Jun 15, 2020

Need to merge 7a0ed35 into your code to get it to pass CI btw, see issue #71

@arm61
Copy link
Contributor

arm61 commented Jun 15, 2020

Given that the notebooks are now too big to open in the Github "view file" option, maybe this can become a chapter in its own right? Fancy breaking them up into separate notebooks?

@j-m-dean
Copy link
Contributor Author

Yeah, given that I am only 1/3 of the way through the topics, that's probably the best course of action.

I'll separate them out this evening.

@arm61
Copy link
Contributor

arm61 commented Jun 16, 2020

This could be the longest chapter 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants