Allow n_heads specification in fp8 attention bench #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Currently fp8 attention benchmark only allows specifying the `embedding_dim` and the `h_dimension`, which leads to inconsistencies with the bf16 benchmark. - Adding support to provide `n_heads` as input and raise `ValueError` incase mismatch between providing inputs. - Dropping default value for `embedding_dim` Differential Revision: D68531784
mandroid6
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
mandroid6
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
This pull request was exported from Phabricator. Differential Revision: D68531784 |
|
This pull request was exported from Phabricator. Differential Revision: D68531784 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D68531784 |
|
This pull request has been merged in 7c730ea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently fp8 attention benchmark only allows specifying the
embedding_dimand theh_dimension, which leads to inconsistencies with the bf16 benchmark.n_headsas input and raiseValueErrorincase mismatch between providing inputs.embedding_dimDifferential Revision: D68531784