avoid extra copy in PackedGemmMatrixB constructor #3691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D69564913 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hl475
approved these changes
Feb 14, 2025
helloguo
added a commit
to helloguo/FBGEMM
that referenced
this pull request
Feb 14, 2025
Summary: X-link: facebookresearch/FBGEMM#767 This diff modifies one of the constructors, to allow pass in pmat instead of always copying the memory. It's uses' responsibility to make sure the passed in parameter is valid. Reviewed By: hl475 Differential Revision: D69564913
helloguo
force-pushed
the
export-D69564913
branch
from
2398bbc to
a1d4d23
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69564913 |
helloguo
added a commit
to helloguo/FBGEMM
that referenced
this pull request
Feb 14, 2025
Summary: X-link: facebookresearch/FBGEMM#767 This diff modifies one of the constructors, to allow pass in pmat instead of always copying the memory. It's uses' responsibility to make sure the passed in parameter is valid. Reviewed By: hl475 Differential Revision: D69564913
helloguo
force-pushed
the
export-D69564913
branch
from
a1d4d23 to
cdc779f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69564913 |
helloguo
added a commit
to helloguo/FBGEMM
that referenced
this pull request
Feb 14, 2025
Summary: X-link: facebookresearch/FBGEMM#767 This diff modifies one of the constructors, to allow pass in pmat instead of always copying the memory. It's uses' responsibility to make sure the passed in parameter is valid. Reviewed By: hl475 Differential Revision: D69564913
helloguo
force-pushed
the
export-D69564913
branch
from
cdc779f to
aaaf813
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69564913 |
helloguo
added a commit
to helloguo/FBGEMM
that referenced
this pull request
Feb 14, 2025
Summary: X-link: facebookresearch/FBGEMM#767 This diff modifies one of the constructors, to allow pass in pmat instead of always copying the memory. It's uses' responsibility to make sure the passed in parameter is valid. Reviewed By: hl475 Differential Revision: D69564913
helloguo
force-pushed
the
export-D69564913
branch
from
aaaf813 to
8e06b5c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69564913 |
helloguo
added a commit
to helloguo/FBGEMM
that referenced
this pull request
Feb 15, 2025
Summary: X-link: facebookresearch/FBGEMM#767 This diff modifies one of the constructors, to allow pass in pmat instead of always copying the memory. It's uses' responsibility to make sure the passed in parameter is valid. Reviewed By: hl475 Differential Revision: D69564913
helloguo
force-pushed
the
export-D69564913
branch
from
8e06b5c to
1835666
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69564913 |
helloguo
added a commit
to helloguo/FBGEMM
that referenced
this pull request
Feb 15, 2025
Summary: X-link: facebookresearch/FBGEMM#767 This diff modifies one of the constructors, to allow pass in pmat instead of always copying the memory. It's uses' responsibility to make sure the passed in parameter is valid. Reviewed By: hl475 Differential Revision: D69564913
helloguo
force-pushed
the
export-D69564913
branch
from
1835666 to
f9eb1ae
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69564913 |
helloguo
added a commit
to helloguo/FBGEMM
that referenced
this pull request
Feb 16, 2025
Summary: X-link: facebookresearch/FBGEMM#767 This diff modifies one of the constructors, to allow pass in pmat instead of always copying the memory. It's uses' responsibility to make sure the passed in parameter is valid. Reviewed By: hl475 Differential Revision: D69564913
helloguo
force-pushed
the
export-D69564913
branch
from
f9eb1ae to
81dc2b4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69564913 |
Summary: X-link: facebookresearch/FBGEMM#767 This diff modifies one of the constructors, to allow pass in pmat instead of always copying the memory. It's uses' responsibility to make sure the passed in parameter is valid. Reviewed By: hl475 Differential Revision: D69564913
helloguo
force-pushed
the
export-D69564913
branch
from
81dc2b4 to
05fe504
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69564913 |
|
This pull request has been merged in 607861a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/767
This diff modifies one of the constructors, to allow pass in pmat instead of always copying the memory. It's uses' responsibility to make sure the passed in parameter is valid.
Differential Revision: D69564913